Feature/parameterise test parms #248
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbjorge
reviewed
Sep 5, 2025
| <properties> | ||
| <maven.compiler.source>17</maven.compiler.source> | ||
| <maven.compiler.target>17</maven.compiler.target> | ||
| <selenium.version>4.35.0</selenium.version> |
Contributor
There was a problem hiding this comment.
Does this break dependabot's ability to keep these up to date?
Author
There was a problem hiding this comment.
not AFAIK. I simply changed this from 4.34.0 because in updating for TestNG and the browser versions I was testing against, 4.34.0 simply did not work. I researched this question specifically I as long as we stick to mainstream releases,then dependabot will not be broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored to remove the testng config, modifying the POM to remove those references, but retaining the parameterised chrome and chromedriver configs.
updated README.md file