feat: update node to v24 #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to update the Node.js version from v20 to v24 across the GitHub Action and CI workflows. However, there are critical issues that prevent this update from working correctly.
- Updates the action runtime from
node20tonode24in action.yml - Changes
.nvmrcfrom version 20 to 24 - Modifies workflow files to use
node-version-fileinstead of hardcoded versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| action.yml | Updates GitHub Action runtime to node24 (unsupported) |
| .nvmrc | Updates Node version from 20 to 24 |
| .github/workflows/yml-checker.yml | Switches to version file reference (incorrect filename) |
| .github/workflows/tests.yml | Switches to version file references (incorrect filename) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
I just updated the description and title to reflect that this is breaking and we should figure out some level of QA validation for it after it lands. |
Garbee
changed the title
Garbee
changed the title
Garbee
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Node 24 now supports proxies using
NODE_USE_ENV_PROXY. While this shouldn't impact most customers unless they are running on self-hosted runner machines, out of an abundance of caution this is a major release because of that impact.Closes: #59