feat: allow users to change error to warning #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new allow_warnings input that allows users to configure the action to report accessibility errors as warnings instead of failing the build. When enabled, errors are still reported but as warnings, and the action completes successfully.
Key Changes:
- Added
allow_warningsboolean input to action configuration with default value offalse - Modified error reporting to conditionally use
core.warning()instead ofcore.error()when warnings are allowed - Updated action behavior to use
core.info()instead ofcore.setFailed()when warnings are allowed and issues are found
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| action.yml | Adds new allow_warnings input parameter with default value 'false' |
| src/types.ts | Extends ActionInputs interface to include allowWarnings boolean field |
| src/run.ts | Parses new input, passes it to linter, and conditionally fails or logs based on the setting |
| src/linter.ts | Accepts allowWarnings parameter and conditionally reports issues as errors or warnings |
| src/run.test.ts | Adds test coverage for the new allow_warnings functionality and updates existing tests to mock the new input |
| src/linter.test.ts | Adds test for warning behavior and updates existing test to explicitly pass the new parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.