Add writable_acl_force to force ACL reset on writable dirs#4140
Merged
antonmedv merged 3 commits intodeployphp:masterfrom Dec 8, 2025
Merged
Add writable_acl_force to force ACL reset on writable dirs#4140antonmedv merged 3 commits intodeployphp:masterfrom
antonmedv merged 3 commits intodeployphp:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new writable_acl_force configuration option to allow forcing ACL (Access Control List) resets on writable directories, even when they already have ACLs configured. This addresses deployment scenarios where directory ACLs on the root level prevent nested paths from receiving proper permissions during recursive ACL operations.
Key changes:
- Added
writable_acl_forceboolean configuration (defaults tofalse) to force ACL reapplication - Updated ACL-checking logic to respect the new force flag in non-sudo scenarios
- Generated documentation for the new configuration option
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| recipe/deploy/writable.php | Adds writable_acl_force configuration and updates ACL logic to check this flag before skipping directories that already have ACLs |
| docs/recipe/deploy/writable.md | Auto-generated documentation for the new writable_acl_force option with source references and default value |
| .gitignore | Adds .idea/ directory (JetBrains IDE configuration) to ignored files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
antonmedv
reviewed
Dec 5, 2025
antonmedv
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix #…?
New feature?
BC breaks?
Tests added?
Docs added?
Explanation: Some writable directories already have ACLs on the root, which makes the existing skip logic skip nested paths when running recursively. The new writable_acl_force option lets users reapply ACLs regardless of the root check so nested directories get the intended permissions, fixing deployments where ACL inheritance was previously missed. That said, this option is mainly intended to be used manually whenever the ACLs seem to be wrong and using sudo is not an option on the system.