fix: detect macOS ACL support using uname instead of chmod output#4137
Merged
antonmedv merged 1 commit intodeployphp:masterfrom Dec 2, 2025
Merged
fix: detect macOS ACL support using uname instead of chmod output#4137antonmedv merged 1 commit intodeployphp:masterfrom
antonmedv merged 1 commit intodeployphp:masterfrom
Conversation
Running `chmod` without arguments to detect macOS ACL support outputs an error: "chmod: missing operand" which clutters deployment logs. Since `chmod +a` is macOS-specific (Linux and FreeBSD use setfacl), directly checking `uname -s === 'Darwin'` is cleaner and more reliable than parsing chmod's error output.
antonmedv
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
deploy:writableruns inaclmode, the code detects macOS ACL support by running:This outputs an error message to the deployment logs:
While the command succeeds (due to
; true), the error message clutters deployment output.Solution
Since
chmod +ais macOS-specific (Linux and FreeBSD usesetfacl/getfaclinstead), we can directly check the OS:This is:
chmod +aReferences
chmod +a/-a/=afor ACL managementsetfacl/getfacl(POSIX ACLs)setfacl/getfacldespite being BSD-based