[SHOPWARE] Fixed edge case where config/jwt/ folder is empty and shell expansion fails.#4101
Merged
antonmedv merged 1 commit intodeployphp:masterfrom Oct 28, 2025
Merged
Conversation
Fixed edge case where `config/jwt/` folder is empty and shell expansion fails.
antonmedv
approved these changes
Oct 28, 2025
Contributor
Author
|
@antonmedv Thanks for taking the time to merge this one in, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue where the
sw:writable:jwttask fails whenever theconfig/jwtfolder does not contain any visible files.From my understanding this is because shells by default do not have the "nullglob" option set. So when it tries to glob the config/jwt directory for files, it does not find any and returns the literal string containing the asterisk. This leads to the error you see below:
One way to fix this is to use the
findcommand instead, which is the change I propose we merge in.Bug fix (no issue opened)
New feature?
BC breaks?
Tests added?
Docs added?