Bugfix dotenv test in laravel.php#4082
Merged
antonmedv merged 7 commits intodeployphp:masterfrom Jun 25, 2025
Merged
Conversation
The test to check if .env file is present was not checking if the dotenv variable was set and always used the default. Added getter for dotenv variable.
Contributor
Author
|
@antonmedv as discussed in #4081 I created a pr for the bug in the laravel recipe for checking the .env file's presence. |
Member
|
I think we also need to change dotenv itself, so it works during deploy: -set('dotenv', '{{current_path}}/.env');
+set('dotenv', '{{release_or_current_path}}/.env'); |
Contributor
Author
|
@antonmedv where should this be added? I cannot find any occurrence of the |
Contributor
Author
|
@antonmedv I'm happy to help but could you point me in the right direction? As stated in my previous comment I cannot find the line of code you shared besides a comment.
|
Member
Change instructions for set dotenv to use release_or_current_path variable.
Contributor
Author
|
@antonmedv just added the commit. |
antonmedv
requested changes
Jun 25, 2025
Change instructions for set dotenv to use release_or_current_path variable.
antonmedv
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test to check if .env file is present was not checking if the dotenv variable was set and always used the default. Added getter for dotenv variable.