Updated to PHP SSH 1.1.1 #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version improves command execution error detection
Author
Author
|
Hello @Elfet, Main problem with php-ssh@1.1.0 is that it relies on stderr to check if executed command failed or not BUT since a few weeks, composer writes a lot of things to stderr that are not errors (see my previous comment for the reasons). Basically, all deployer users that uses composer during deployment (so a good majority of its users) will get a RuntimeException during composer install step. I've fixed the problem on php-ssh, all you have to do now is to update deployer, and then we can share a 🍻 |
|
👍 |
Member
|
Great! Sorry about delay. 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version improves command execution error detection