Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I'm trying to fix dependabot/dependabot-core#16479, by adding
releases.nixos.orgto the egress allowlist.The problem is that
channels.nixos.org302-redirects toreleases.nixos.orgbreaking automatic updates when tracking channel tarballs.Anything you want to highlight for special attention from reviewers?
I just added the exact domain to the allowlist. If extra tests for this are required, let me know.
How will you know you've accomplished your goal?
A flake with the following input:
shows the chain of redirects. With this change I expect everything to resolve to 200 status codes and Dependabot should be able to update these inputs again.
Checklist