Pin numpy version to <2.0.0 for now. #907
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-dawg78
requested review from
Faylixe,
alreadytaikeune,
mmoussallam and
romi1502
as code owners
|
Why? |
Spleeter is stuck in the Python 3.10 era — anything newer simply breaks. Here’s the ugly but necessary workaround I use with the UV package manager: [project]
name = "example"
version = "1.0"
description = "demo"
requires-python = "==3.10.*"
dependencies = [
"numpy<2",
"spleeter>=2.4.0",
# "tensorflow-io-gcs-filesystem==0.31.0", # needed for windows dev?
]Be aware: pinning NumPy this low might blow up compatibility with any modern dependencies you have. But hey — welcome to the wonderful world of Python’s amazing dependency management, where pip happily lets everything burn until you fix it yourself. UV is, at least, sane enough to handle most of these dependency dumpster fires. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title
Description
A few sentences describing the overall goals of the pull request's commits.
How this patch was tested
You tested it, right?
poetry run pytest tests/poetry run black spleeterDocumentation link and external references
Please provide any info that may help us better understand your code.