Refactor FigureExtractor to have client/core features. Closes #1760#1771
Merged
Refactor FigureExtractor to have client/core features. Closes #1760#1771
Conversation
brollb
requested changes
Jul 15, 2020
Contributor
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
Good start! See comments below.
1. All the functions using client/core changed to operate on NodeInfoJSON 2. Address PR review suggestions 3. Grab GraphNode from controllers: `PlotlyGraphControl`, `ExecutionIndexControl`
1. Fix nodejs btoa function unavailability 2. Change FigureReference.json to a single line 3. Refactor extract method to both client/core FigureExtractor
brollb
reviewed
Jul 17, 2020
| desc = { | ||
| id: id, | ||
| execId: execId, | ||
| type: this.getMetaType(nodeInfo) === EXTRACTORS.PLOT3D ? 'plot3D' : 'plot2D', |
Contributor
There was a problem hiding this comment.
Why is "plot2D" lowercase here (rather than conforming to the earlier "Plot2D"? Since this isn't a change added in this commit, it doesn't need to be changed here but I just find it a bit odd...
Contributor
Author
Also, add test to check equality of objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1760.