Remove deployment env variables from docker-compose. Fixes #1755#1756
Merged
Remove deployment env variables from docker-compose. Fixes #1755#1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the
DEEPFORGE_HOSTenvironment variable to the deployment overrides. It was initially included there as a bit of an example as it is required to be overwritten before using some of the compute backends. However, it is easy to overlook when spinning up a local instance to test it out and checking.deployment/docker-compose-overrides.ymlshould provide a reasonable example if someone is looking for an example of how to configure a full-fledged custom deployment.