Add support for Temporary volume pool in sciserver-files. Closes #1635.#1636
Merged
Add support for Temporary volume pool in sciserver-files. Closes #1635.#1636
Conversation
brollb
requested changes
Apr 10, 2020
Contributor
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
Nice work. I left some comments below.
test/assets/configs/storage.js
Outdated
| const username = getSciServerUsername(); | ||
| const password = getSciServerPassword(); | ||
| const volume = `${username}/deepforge_test`; | ||
| const volumePool = 'Storage'; |
Contributor
There was a problem hiding this comment.
We should probably change this to "Temporary" now that we are making this possible.
This was referenced Apr 10, 2020
brollb
approved these changes
Apr 14, 2020
Contributor
|
@umesh-timalsina - could you look into the failing tests? |
Contributor
Author
|
Initially, the tests were failing because lack of volume called |
Contributor
Author
|
@brollb The tests are passing now. LGTM!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.