Add help message on conda environment creation error. Closes #1526#1536
Open
umesh-timalsina wants to merge 1 commit intomasterfrom
Open
Add help message on conda environment creation error. Closes #1526#1536umesh-timalsina wants to merge 1 commit intomasterfrom
umesh-timalsina wants to merge 1 commit intomasterfrom
Conversation
brollb
requested changes
Jul 21, 2020
Contributor
brollb
left a comment
There was a problem hiding this comment.
There are a couple main issues with this:
- There is no check ensuring that the creation command failed because the environment already exists. For example, if conda isn't installed, this will still suggest running the command with
--forcewhich won't help at all. We could probably either check the error message or the exit code. I am not sure that the exit code will be very precise or cross platform. - As a minor point, it is already logged that the command failed so we can probably just remove that so we aren't repeating ourselves in the logs.
- We should not use
__dirnamein the logs as this will print weird paths. For example, if we install deepforge with nvm, this will print a long path like/home/brian/.nvm/versions/node/v12.14.1/bin/browserify. This is not likely the path the user used to run the command so it's a bit strange. It's easier just to avoid this and suggest adding the '--force' flag to overwrite any existing environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.