Fix for Overflow in finding Square root of an Integer

deepcodingios · deepcodingios · commit 829111e4f322 · 2023-01-18T07:48:49.000+05:30
diff --git a/src/Arrays/MaxSubArraySum.java b/src/Arrays/MaxSubArraySum.java
@@ -0,0 +1,11 @@
+package Arrays;
+
+public class MaxSubArraySum {
+    public static void main(String[] args) {
+        
+    }
+    
+    static void MaxSubArraySumForLength(int [] A, int length){
+
+    }
+}
diff --git a/src/Basics/SquareRootOfNumber.java b/src/Basics/SquareRootOfNumber.java
@@ -6,12 +6,12 @@
 public class SquareRootOfNumber {
     public static void main(String[] args) {
 
-        // int result = findSquareRootOfNumber(121);
-        int result = findSquareRootOfNumberWithBinarySearch(0);
+        // long result = findSquareRootOfNumber(930675566);
+        int result = findSquareRootOfNumberWithBinarySearch(930675566);
         System.out.println(result);
     }
 
-    static int findSquareRootOfNumber(int number){
+    static long findSquareRootOfNumber(long number){
 
         // Base cases
         if (number == 0 || number == 1)
@@ -24,7 +24,7 @@ static int findSquareRootOfNumber(int number){
         while (result < number) {
             i++;
             result = i * i;
-            System.out.println(i + " " + result);
+            // System.out.println(i + " " + result);
         }
 
         if (i*i == number){
@@ -42,20 +42,19 @@ static int findSquareRootOfNumberWithBinarySearch(int A){
 
         while(startIndex <= lastIndex){
 
-            int middleIndex = startIndex + (lastIndex - startIndex)/2;
+            int middleIndex = startIndex + ((lastIndex - startIndex)/2);
 
             if(A == middleIndex*middleIndex){
                 return middleIndex;
             }
-            else if(middleIndex*middleIndex < A){
+            else if(middleIndex <= A/middleIndex){
                 answer = middleIndex;
                 startIndex = middleIndex+1;
 
             }else{
 
                 lastIndex = middleIndex -1;
             }
-
         }        
         return answer;
     }
