add support for chrome apps #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browser.js
Outdated
Contributor
There was a problem hiding this comment.
chrome.storage.local !== undefined
// ReferenceError: Can't find variable: chromein every browser other than chrome
added 2 commits
October 8, 2014 17:27
Sorry, this should work now. window.localStorage is undefined in chrome apps.
Contributor
Author
|
Ok thanks for the correction... now it should work :)) |
TooTallNate
added a commit
that referenced
this pull request
Dec 29, 2014
add support for chrome apps
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a chrome app, it appears the following error:
window.localStorage is not available in packaged apps. Use chrome.storage.local instead.