Don't set DEBUG if namespaces is undefined. #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node.js
Outdated
Contributor
There was a problem hiding this comment.
Let's do if (null == namespaces) (double equals instead of triple). It means the same thing.
Contributor
|
Good catch! A few nits but once those are fixed I'll merge. |
Contributor
Author
|
Nits fixed. Thanks! |
Contributor
|
While you're at it, can you do the same kind of fix in |
On Node.js, if you set a process.env field to either null or undefined, it gets cast to string 'null' or 'undefined'. For debug, this means that if you don't have DEBUG set, it will get set to the string 'undefined'. There are other modules (like node-rest-client) which use the DEBUG environment variable that will start spewing debug output when you don't want it to.
Contributor
Author
|
Done. |
Contributor
|
Sweet. Thanks! |
TooTallNate
added a commit
that referenced
this pull request
Jun 6, 2014
Don't set DEBUG if namespaces is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Node.js, if you set a process.env field to either null or undefined,
it gets cast to string 'null' or 'undefined'.
For debug, this means that if you don't have DEBUG set, it will get set
to the string 'undefined'. There are other modules (like
node-rest-client) which use the DEBUG environment variable that will
start spewing debug output when you don't want it to.