Feature: Improve asteroid game scoring system with enhanced reward logic and new accuracy metrics.

deanthecoder · deanthecoder · commit ed65c213b867 · 2025-04-20T18:06:25.000+01:00
diff --git a/G33kShell.Desktop/Console/Screensavers/AI/AiGameCanvasBase.cs b/G33kShell.Desktop/Console/Screensavers/AI/AiGameCanvasBase.cs
@@ -102,7 +102,7 @@ private void TrainAiImpl(Action<byte[]> saveBrainBytes)
         var stats = $"Gen {m_generation}|Pop {m_currentPopSize}|Rating {veryBest.Rating:F1}|GOAT {m_savedRating:F1}";
         var extraStats = veryBest.ExtraGameStats().Select(o => $" {o.Name}: {o.Value}").ToArray().ToCsv().Trim();
         if (!string.IsNullOrEmpty(extraStats))
-            stats += $" | {extraStats}";
+            stats += $"|{extraStats}";
         System.Console.WriteLine(stats);
 
         // Persist brain improvements.
diff --git a/G33kShell.Desktop/Console/Screensavers/Asteroids/Game.cs b/G33kShell.Desktop/Console/Screensavers/Asteroids/Game.cs
@@ -21,6 +21,7 @@ namespace G33kShell.Desktop.Console.Screensavers.Asteroids;
 public class Game : AiGameBase
 {
     private int m_bulletsFired;
+    private int m_asteroidsHit;
     private int m_perfectHits;
     private int m_gameTicks;
     private int m_leftTurns;
@@ -39,43 +40,35 @@ public override double Rating
         get
         {
             if (Score == 0)
-                return -50.0; // Penalize pacifists.
-
+                return 0.0; // Penalize pacifists.
             if (m_gameTicks > 2000 && m_bulletsFired < 5)
-                return -100.0; // Penalize idle campers.
-
-            var accuracyScore = HitAccuracy * 25.0;                        // Strongly reward aiming carefully.
-            var perfectHitBonus = m_perfectHits * 1.0;                     // Bigger incentive for intentional targeting.
-            var shotDiscipline = -(m_bulletsFired - m_perfectHits) * 0.02; // Stronger spam punishment.
-            var rawScore = Score / 180.0;                                  // Increase actual game score importance.
+                return 0.0; // Penalize idle campers.
+            if (TurnEquality < 0.3)
+                return 0.0; // Penalize wonky-turners.
+            if (m_thrustTicks == 0)
+                return 0.0; // Penalize non-thrusters.
 
-            // Reward repositioning, but penalize constant thrust with no balance.
             var thrustRatio = m_thrustTicks / (double)m_gameTicks;
-            var repositioningBonus = thrustRatio > 0.2 && thrustRatio < 0.8 ? 5.0 : -2.0;
-
-            // Strongly penalize sustained unidirectional spinning:
-            var turnReward = TurnEquality > 0.5 ? TurnEquality * 5.0 : -5.0;
-
-            // Introduce a simple collision-avoidance reward:
-            var survivalBonus = m_gameTicks / 4500.0; // Survive longer by avoiding collisions.
-
-            return rawScore + accuracyScore + perfectHitBonus +
-                   shotDiscipline + repositioningBonus +
-                   turnReward + survivalBonus;
+            var survivalBonus = (m_gameTicks / 8000.0).Clamp(0.0, 1.0);
+
+            return Score / 8000.0 * 10.0 +
+                   HitRatio * 0.5 * 0.1 +
+                   PerfectHitRatio * 1.0 * 0.1 +
+                   thrustRatio * 2.0 * 0.1 +
+                   TurnEquality * 0.5 * 0.1 +
+                   survivalBonus * 1.0 * 0.1
+                   ;
         }
     }
     
     public override IEnumerable<(string Name, string Value)> ExtraGameStats()
     {
         yield return ("Score", Score.ToString());
-        yield return ("HitAccuracy", HitAccuracy.ToString("P1"));
-        yield return ("GameTicks", m_gameTicks.ToString());
+        yield return ("Accuracy", HitRatio.ToString("P1"));
+        yield return ("Perfect", PerfectHitRatio.ToString("P1"));
+        yield return ("Ticks", m_gameTicks.ToString());
         yield return ("TurnEquality", TurnEquality.ToString("P1"));
-        yield return ("BulletsFired", m_bulletsFired.ToString());
-        yield return ("PerfectHits", m_perfectHits.ToString());
-        yield return ("LeftTurns", m_leftTurns.ToString());
-        yield return ("RightTurns", m_rightTurns.ToString());
-        yield return ("ThrustTicks", m_thrustTicks.ToString());
+        yield return ("Thrusts", m_thrustTicks.ToString());
     }
 
     private double TurnEquality
@@ -94,7 +87,8 @@ private double TurnEquality
     public List<Asteroid> Asteroids { get; } = [];
     public List<Bullet> Bullets { get; } = [];
 
-    private double HitAccuracy => m_bulletsFired == 0 ? 0.0 : (double)m_perfectHits / m_bulletsFired;
+    private double PerfectHitRatio => m_bulletsFired == 0 ? 0.0 : (double)m_perfectHits / m_bulletsFired;
+    private double HitRatio => m_bulletsFired == 0 ? 0.0 : (double)m_asteroidsHit / m_bulletsFired;
 
     public Game(int arenaWidth, int arenaHeight) : base(arenaWidth, arenaHeight, new Brain())
     {
@@ -110,6 +104,7 @@ public override Game ResetGame()
         Bullets.Clear();
         m_bulletsFired = 0;
         m_perfectHits = 0;
+        m_asteroidsHit = 0;
         m_gameTicks = 0;
         m_leftTurns = 0;
         m_rightTurns = 0;
@@ -199,6 +194,7 @@ public override void Tick()
             // Bonus points if it was the asteroid we were aiming for.
             if (bullet.Target == hitAsteroid)
                 m_perfectHits++;
+            m_asteroidsHit++;
         }
 
         for (var i = 0; i < bulletsToRemove.Count; i++)
