Skip to content

Incorrect path concatenation #46

New issue
New issue
Closed
Closed
Incorrect path concatenation#46

Description

@EltonCN
EltonCN
opened on Nov 18, 2020

Using with Windows, the "os.path.join(model_base_path, weights_manifest_path)" in line 81 of download.py generates a wrong URL with "" separator.

Changing to "model_base_path+"/"+weights_manifest_path" corrected the problem

Activity

  1. de-code commented on Nov 19, 2020

    @de-code
    de-code
    on Nov 19, 2020
    Owner

    Thank you for reporting the issue. I guess that is only an issue when model_base_path is not a local path?

  2. de-code commented on Nov 19, 2020

    @de-code
    de-code
    on Nov 19, 2020
    Owner

    It's fixed in source and will be included in the next release

  3. de-code commented on Nov 19, 2020

    @de-code
    de-code
    on Nov 19, 2020
    Owner

    The fix is now released (v0.3.3)

  4. de-code
    closed this as completedon Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions