server/src/main/scala/org/dbpedia/extraction/server/stats/MappingStatsHolder.scala (2)

54-55: Remove commented-out code.

The commented-out "simple fix" implementation should be removed before merging. Version control preserves the history, so there's no need to keep it in the code.

Apply this diff:

-       // Simple fix (commented out): just filter out invalid redirects silently
-      // val redirects = wikiStats.redirects.filterKeys(title => title.startsWith(templateNamespace) && templateMappings.contains(title.substring(templateNamespace.length))).map(_.swap)
-

---

57-65: Core fix is correct; consider refactoring for efficiency and to avoid deprecated method.

The validation logic properly prevents the IndexOutOfBoundsException by ensuring titles start with templateNamespace before calling substring. The logging is consistent with the pattern used for templates (lines 29-51).

However, consider these improvements:

1. filterKeys is deprecated in Scala 2.13+
2. The two-stage filtering could be combined into a single pass for better performance

Apply this diff to combine filters and avoid the deprecated method:

-      // Better fix: filter out invalid redirects with warning logging
-      val redirects = wikiStats.redirects.filter { case (title, _) =>
-        if (title.startsWith(templateNamespace)) {
-          true
-        } else {
-          logger.warning(language.wikiCode + " redirect '" + title + "' does not start with '" + templateNamespace + "'")
-          false
-        }
-      }.filterKeys(title => templateMappings.contains(title.substring(templateNamespace.length))).map(_.swap)
+      // Better fix: filter out invalid redirects with warning logging
+      val redirects = wikiStats.redirects.filter { case (title, target) =>
+        if (title.startsWith(templateNamespace)) {
+          templateMappings.contains(title.substring(templateNamespace.length))
+        } else {
+          logger.warning(language.wikiCode + " redirect '" + title + "' does not start with '" + templateNamespace + "'")
+          false
+        }
+      }.map(_.swap)

Optionally, for better readability, use string interpolation:

-          logger.warning(language.wikiCode + " redirect '" + title + "' does not start with '" + templateNamespace + "'")
+          logger.warning(s"${language.wikiCode} redirect '$title' does not start with '$templateNamespace'")

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro