-
Notifications
You must be signed in to change notification settings - Fork 291
GSOC final pull request #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@celian_ringwald @datalogism — Are these all intermingled and/or interdependent? If not, it seems to me that each GSOC work item should have its own PR, rather than all being mushed into one. This will make all of them easier to review, among other things. (I recognize that it would be more work on your part, but I do think it would be worthwhile.) |
core/src/main/scala/org/dbpedia/extraction/util/MediawikiConnectorConfigured.scala
Outdated
Show resolved
Hide resolved
dump/src/test/scala/org/dbpedia/extraction/dump/ExtractionTestAbstract.md
Outdated
Show resolved
Hide resolved
dump/src/test/scala/org/dbpedia/extraction/dump/ExtractionTestAbstract.scala
Outdated
Show resolved
Hide resolved
TallTed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed commit by commit....
dump/src/test/scala/org/dbpedia/extraction/dump/ExtractionTestAbstract.scala
Outdated
Show resolved
Hide resolved
Sorry @TallTed I had no instructions about this, this is my first main pull request :s |
…ctorConfigured.scala Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
…Abstract.md Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
…Abstract.scala Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
…Abstract.scala Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
core/src/main/scala/org/dbpedia/extraction/util/MediawikiConnectorConfigured.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/dbpedia/extraction/util/MediawikiConnectorConfigured.scala
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |








Pushing all the work made during the GSOC