Skip to content

Conversation

@datalogism
Copy link
Member

Pushing all the work made during the GSOC

@TallTed
Copy link
Contributor

TallTed commented Sep 14, 2022

@celian_ringwald @datalogism — Are these all intermingled and/or interdependent? If not, it seems to me that each GSOC work item should have its own PR, rather than all being mushed into one. This will make all of them easier to review, among other things. (I recognize that it would be more work on your part, but I do think it would be worthwhile.)

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit by commit....

@datalogism
Copy link
Member Author

@celian_ringwald @datalogism — Are these all intermingled and/or interdependent? If not, it seems to me that each GSOC work item should have its own PR, rather than all being mushed into one. This will make all of them easier to review, among other things. (I recognize that it would be more work on your part, but I do think it would be worthwhile.)

Sorry @TallTed I had no instructions about this, this is my first main pull request :s

datalogism and others added 4 commits September 16, 2022 18:04
…ctorConfigured.scala

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
…Abstract.md

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
…Abstract.scala

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
…Abstract.scala

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
datalogism and others added 2 commits September 16, 2022 18:04
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jlareck jlareck merged commit 5b8d052 into dbpedia:celian-gsoc Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants