Skip to content

Fix merging multiple infoboxes #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jlareck merged 28 commits into from
Sep 17, 2021
Merged

Fix merging multiple infoboxes #710

jlareck merged 28 commits into from
Sep 17, 2021

Conversation

@mubashar1199
Copy link
Contributor

@mubashar1199 mubashar1199 commented Aug 31, 2021

Solved the issue #709, also added a new SHACL test and new page to minidump for testing

@jlareck
Copy link
Collaborator

jlareck commented Aug 31, 2021 •
edited
Loading

@mubashar1199 please move #Marian_Breland_Bailey,yes,yes from testGroups.csv file to shacl-test-groups.csv. And delete the dump/src/test/resources/testGroups.csv, because for loading test groups we use shacl-test-groups.csv in dev branch and testGroups.csv was deleted

@mubashar1199
Copy link
Contributor Author

mubashar1199 commented Sep 1, 2021

@mubashar1199 please move #Marian_Breland_Bailey,yes,yes from testGroups.csv file to shacl-test-groups.csv. And delete the dump/src/test/resources/testGroups.csv, because for loading test groups we use shacl-test-groups.csv in dev branch and testGroups.csv was deleted

Done, please see now

@JJ-Author JJ-Author requested a review from jlareck September 1, 2021 08:54
jlareck
jlareck requested changes Sep 2, 2021
View reviewed changes
@jlareck
Copy link
Collaborator

jlareck commented Sep 2, 2021

@mubashar1199 PR is good, but there are some places where you just need to clean the code a little bit (I wrote the comments where you should do it)

jlareck and others added 23 commits September 2, 2021 22:08
@jlareck
fix build error
6b64375
@kurzum
Update data.md
745ebc5
@jlareck @mubashar1199
added removing broken information parentheses e.g (; born November 20…
854a1b6 
…, 1942) or ()
@jlareck @mubashar1199
fixed removing brackets in abstracts
24d6489
@jlareck @mubashar1199
added removing broken paranthesis
9a8a4f5
@jlareck @mubashar1199
removed normalized tags
eeb6bc5
@jlareck @mubashar1199
implemented shacl test for abstracts
8647458
@jlareck @mubashar1199
made choosing the removing of brackets in properties file
1d220f8
@Vehnem @mubashar1199
Github action minidumpdoc update
c1d567f
@kurzum @mubashar1199
Update dbp_abstract.ttl
b38bad7
@jlareck @mubashar1199
Implement construct validation tests selection (dbpedia#704)
39d9541
@jlareck @mubashar1199
Fix abstract extraction (dbpedia#705)
204b01c 
* implement selection of construct validation tests

* rename test report file of construct validation tests

* fix path to test reports directory

* add removing brackets that start with "(,"

* make removing broken brackets in WikipediaNifExtractor configurable

* rename abstract extractors

* fix getting short abstracts in WikipediaNifExtractor

* generate two dumps for plain and html abstract extractors

* fix minidump abstract extraction
@jlareck @mubashar1199
Implement handling of right and left validators (dbpedia#706)
2c1c373 
* add Construct model

* add construct validation test for (; in abstracts

* implement handling of right and left validators
@jlareck @mubashar1199
implement unit test for removing bracket method and fixed construct v…
dc6ccd7 
…alidation tests
@jlareck @mubashar1199
add more unit tests for removing broken brackets function
17be121
@jlareck @mubashar1199
move remove brackets function to AbstractUtils
3f5c923
@jlareck @mubashar1199
move AbstractUtils to abstracts package and implement test for issue d…
cff66f5 
…bpedia#626
@mubashar1199
Modified TemplateMapping.scala file to fix merging of multiple info b…
9988452 
…oxes under one resource, see issue 709
@mubashar1199
modified uris.lst list to add new page in minidump for testing
7c8835f
@mubashar1199
created new SHACL test, added it in shacl-test-groups.csv and disable…
60d88e6 
…d isbn test
@mubashar1199
resolved shacl conflict
9b9737c
@mubashar1199
renamed testGroups.csv to shacl-test-groups.csv
55321e9
@mubashar1199
proper indentation and code organization
3d589f5
@mubashar1199 mubashar1199 force-pushed the fixMergingMultipleInfoboxes branch from 8359158 to 3d589f5 Compare September 3, 2021 08:45
@mubashar1199 mubashar1199 force-pushed the fixMergingMultipleInfoboxes branch from 789ce14 to f68cefa Compare September 3, 2021 09:04
@mubashar1199
Copy link
Contributor Author

mubashar1199 commented Sep 3, 2021

@mubashar1199 PR is good, but there are some places where you just need to clean the code a little bit (I wrote the comments where you should do it)

Thanks, done.

@mubashar1199 mubashar1199 requested a review from jlareck September 3, 2021 09:10
jlareck
jlareck reviewed Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@jlareck jlareck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! PR is cool but you still need to make some small changes

@mubashar1199 mubashar1199 force-pushed the fixMergingMultipleInfoboxes branch from e584c06 to 1e90348 Compare September 9, 2021 11:06
@mubashar1199
Copy link
Contributor Author

mubashar1199 commented Sep 9, 2021

Great job! PR is cool but you still need to make some small changes

Thank you, both changes are made.

@mubashar1199 mubashar1199 requested a review from jlareck September 9, 2021 11:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jlareck jlareck merged commit 22d089e into dbpedia:dev Sep 17, 2021
jlareck pushed a commit to jlareck/extraction-framework that referenced this pull request Sep 17, 2021
@mubashar1199 @jlareck
Fix merging multiple infoboxes (dbpedia#710)
d7cefdf 
* Fix merging of multiple infoboxes under one resource, see issue dbpedia#709
* Add new page to the minidump for testing
* Create SHACL test, add it to the shacl-test-groups.csv and disabled isbn test
@mubashar1199
Copy link
Contributor Author

mubashar1199 commented Sep 17, 2021

@jlareck Thanks for merging, can you provide me any contribution letter/certificate from DBpedia for research purpose?

@jlareck
Copy link
Collaborator

jlareck commented Sep 17, 2021

@JJ-Author @Vehnem is it possible to provide any contribution letter for @mubashar1199 from DBpedia?

@JJ-Author
Copy link
Contributor

JJ-Author commented Sep 24, 2021

@mubashar1199 please send a mail to dbpedia@infai.org

@mubashar1199
Copy link
Contributor Author

mubashar1199 commented Sep 28, 2021

@mubashar1199 please send a mail to dbpedia@infai.org

Sent few days ago, but no response yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlareck jlareck Awaiting requested review from jlareck

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mubashar1199 @jlareck @JJ-Author @kurzum @Vehnem