improve external link parsing #702
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
Warning Rate limit exceeded@JJ-Author has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
|
||
| // Check if this uri has a scheme. If it does not, add a default http:// scheme | ||
|
|
||
| // Check if this uri has a scheme. If it does not, add a default http:// scheme |
There was a problem hiding this comment.
| // Check if this uri has a scheme. If it does not, add a default http:// scheme | |
| // Check whether this URI has a scheme. If it does not, add a default http:// scheme |
Most of the LinkParserTest we failing and this PR fixes most of these tests. There are still issues with external links with paths (containing
?) this is due to the URI escaping utils and not addressed in this change