HomepageExtractor config: return default empty values for undefined settings in a language #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default values in case any of the HomepageExtractor required config does not exist for a specific language (e.g. there is no official website template in itwiki, but there is an official keyword used in external links section). Not using English as default because it looks like a strong assumption which is likely to be either wrong or disruptive.
jimkont
added a commit
that referenced
this pull request
Jan 20, 2014
HomepageExtractor config: return default empty values for undefined settings in a language
jimkont
added a commit
to jimkont/extraction-framework
that referenced
this pull request
Mar 26, 2015
HomepageExtractor config: return default empty values for undefined settings in a language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default values in case any of the HomepageExtractor required config does not exist
for a specific language (e.g. there is no official website template in itwiki, but
there is an official keyword used in external links section).
Not using English as default because it looks like a strong assumption which is likely
to be either wrong or disruptive.