Various enhancements for Live #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Exception#getMessage() can return null.
Wouldn't it better to use Exception#toString() ? At least you get a clue about the nature of the Exception
Member
Author
There was a problem hiding this comment.
In this case I need to do general change in Live module (in another commit).
I got the framework full of this kind of logging and I kept the same style
Contributor
|
Created issue #148 for a general change in Live module. |
ninniuz
added a commit
to jimkont/extraction-framework
that referenced
this pull request
Mar 26, 2015
Various enhancements for Live
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tested commits for DBpedia Live that include