Fix HomepageExtractor issues #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
cleanProperty may return "" and will be turned to "http://", maybe we can save some computation if we skip the empty strings from now
The HomepageExtractor was not able to correctly detect references to official webpages when conveyed through templates placed in the External links section. Only matches to Template:Official were considered and the URL extraction was failing when the template property contained an ExternalLinkNode. With this change: - A map is provided to store info about official website templates, for different langs - Template redirects are checked when looking for official websites - URL is extracted also when the template property is an ExternalLinkNode I was able to extract 550k homepages from enwiki-20130604 compared to about 505k items without this patch (about 10% more).
jimkont
added a commit
to jimkont/extraction-framework
that referenced
this pull request
Mar 26, 2015
Fix HomepageExtractor issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HomepageExtractor was not able to correctly detect references to official webpages
when conveyed through templates placed in the External links section.
Only matches to Template:Official were considered and the URL extraction was failing
when the template property contained an ExternalLinkNode.
With this change:
I was able to extract 550k homepages from enwiki-20130604 compared to about 505k items
without this patch (about 10% more).