update pip install in contribution guide to handle zsh#216
Merged
amjith merged 1 commit intodbcli:mainfrom Feb 28, 2025
Merged
Conversation
amjith
reviewed
Feb 28, 2025
| ```bash | ||
| $ pip install --editable .[dev] | ||
| # zsh workaround | ||
| $ pip install --editable ".[dev]" |
Member
There was a problem hiding this comment.
This should work on both bash and zsh. Rather than having two separate lines I'd much rather have one that works in both shells. Could you remove the other line?
Contributor
Author
There was a problem hiding this comment.
Good call! Just updated.
zachvalenta
force-pushed
the
contributing-zsh-fix
branch
from
2415943 to
7ed2cac
Compare
zachvalenta
changed the title
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update pip install in contribution guide to handle zsh. My thinking here was that given zsh is the now macOS default there might be others who run into this.
Checklist
CHANGELOG.mdfile.