Fixed bug in Bellman Ford data.js

duaraghav8@gmail · duaraghav8@gmail · commit f05d2e2c1751 · 2016-05-22T17:39:30.000+05:30
diff --git a/algorithm/graph_search/bellman_ford/shortest_path/code.js b/algorithm/graph_search/bellman_ford/shortest_path/code.js
@@ -38,17 +38,19 @@ function BELLMAN_FORD (src, dest) {
 	}
 
 	//check for cycle
+	tracer._print ('checking for cycle');
 	for (currentNode = 0; currentNode < G.length; currentNode++) {
 		for (currentNodeNeighbor = 0; currentNodeNeighbor <= G.length; currentNodeNeighbor++) {
 			if (G [currentNode] [currentNodeNeighbor]) {
 				if ( weights [currentNodeNeighbor] > (weights [currentNode] + G [currentNode] [currentNodeNeighbor]) ) {
+					tracer._print ('A cycle was detected: weights [' + currentNodeNeighbor + '] > weights [' + currentNode + '] + ' + G [currentNode] [currentNodeNeighbor]);
 					return (MAX_VALUE);
 				}
 			}
 		}
 	}
 
-	tracer._print ('Final weights for the source ' + src + ' are: [' +  weights + ']');
+	tracer._print ('No cycles detected. Final weights for the source ' + src + ' are: [' +  weights + ']');
 
 	return weights [dest];
 }
diff --git a/algorithm/graph_search/bellman_ford/shortest_path/data.js b/algorithm/graph_search/bellman_ford/shortest_path/data.js
@@ -1,5 +1,4 @@
 var tracer = new DirectedGraphTracer();
-//var G = WeightedGraph.random( (Math.random () * 10) | 0, .3, -9, 9);
 var G = [
 	[0,-1,4,0,0],
 	[0,0,3,2,2],
@@ -8,4 +7,4 @@ var G = [
 	[0,0,0,-3,0]
 ];
 
-tracer._setData(G);
+tracer._setData(G);

Original file line number	Diff line number	Diff line change
`@@ -38,17 +38,19 @@ function BELLMAN_FORD (src, dest) {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`//check for cycle`
	`41`	`+ tracer._print ('checking for cycle');`
`41`	`42`	`for (currentNode = 0; currentNode < G.length; currentNode++) {`
`42`	`43`	`for (currentNodeNeighbor = 0; currentNodeNeighbor <= G.length; currentNodeNeighbor++) {`
`43`	`44`	`if (G [currentNode] [currentNodeNeighbor]) {`
`44`	`45`	`if ( weights [currentNodeNeighbor] > (weights [currentNode] + G [currentNode] [currentNodeNeighbor]) ) {`
	`46`	`+ tracer._print ('A cycle was detected: weights [' + currentNodeNeighbor + '] > weights [' + currentNode + '] + ' + G [currentNode] [currentNodeNeighbor]);`
`45`	`47`	`return (MAX_VALUE);`
`46`	`48`	`}`
`47`	`49`	`}`
`48`	`50`	`}`
`49`	`51`	`}`
`50`	`52`
`51`		`- tracer._print ('Final weights for the source ' + src + ' are: [' + weights + ']');`
	`53`	`+ tracer._print ('No cycles detected. Final weights for the source ' + src + ' are: [' + weights + ']');`
`52`	`54`
`53`	`55`	`return weights [dest];`
`54`	`56`	`}`