Fix some issues causing corruption when reading Amiga disks #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…valid (the Amiga checksum algorithm is weak and zero bytes don't contribute to the checksum).
davidgiven
added a commit
that referenced
this pull request
Oct 11, 2020
Fix some issues causing corruption when reading Amiga disks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Amiga disk checksum algorithm is trash; I'm seeing a lot of spurious false positives, including a completely truncated sector being marked as good (because the checksum of 00 00 00 00... is 0). Plus, two bit errors in the same sector can cancel out and not be detected.