Generators for ESP32 S3 and S3mini - #112
bill-fitch4793 wants to merge 6 commits into
Conversation
|
Development board Version E should use the same files |
|
I notice that there are three MDF's with the id of '0D20' and the same version number |
There was a problem hiding this comment.
I don't see this file used anywhere. Was this file something you created first and then merged into generate_CANMIO.py ?
|
its the CANEPMIOxx trio of files, and I see then in the 'files changed' tab |
| { | ||
| "generated": "Generated by generators/generate_CANMIO.py -t CDU -p23 -v 4d", | ||
| "timestamp": "202609011524", | ||
| "generated": "Generated by ./generators/generate_CANMIO.py -t CDU -p23 -v 4d", |
There was a problem hiding this comment.
Hmm, this is not right. I guess you ran the generator as "sh ./generators/generate_all.sh" where I ran it as "sh generators/generate_all.sh".
Tiny, subtle difference. But it is annoying that all files are regenerated and get a new timestamp just because of this little difference.
Please revert these JSON files and run the generator with "sh generators/generate_all.sh" next time.
I'll add a todo item for myself to fix the generate_all.sh script to trim off the "./" from the path.
There was a problem hiding this comment.
But I didn't run the generator - I just viewed the files in your push request....
There was a problem hiding this comment.
The comment was for Bill.
|
I am thinking more about how we work with MDF's for own projects. One thing is to use the DEV manufacturer ID (13). Another is where to keep them, which implies how widely they are spread. When we started the ModuleDescriptor project we kept all MDF's we could come up with here. Later we realised that this is not the best idea. Instead we have moved to keep the MDF's for user projects within the application code repository. This is what we do for all the VLCB-Arduino example sketches now. However there are still a few example MDF's left here. My own Arduino projects keep their MDF's with the sources. This goes for CANNX and CANLDR. Keeping the MDF's with the application source makes it easier to keep the application and MDF in sync. I would actually argue for doing the same with existing MDF's for CBUS modules that exist in the kitlocker. But there are too many obstacles for this to be a reality. Keeping DEV projects here means that the module ID must be unique, which defeats the purpose of the DEV manufacturerID. So, I suggest that you move the MDF's for your ESP projects to your own repository. Yes, I admit this is contrary to what I wrote on the forum a while ago. Sorry about the confusion. |
|
Yes, I had very similar thoughts about what MDF's are published with MMC, during a session I was on with Thames Valley AG last night. |
3 participants
S3 can use 8 16 or 24 channels. S3 mini can use 8 channels. Only other board that will work is the Development board Version E which I have not yet tested.