Repository navigation
Fix misleading RRULE UNTIL timezone mismatch error message - #1640
Open
eroshanbin-glitch wants to merge 3 commits into
Open
eroshanbin-glitch wants to merge 3 commits into
eroshanbin-glitch wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #851.
The existing RRULE validation raises a
ValueErrorwhenDTSTARTandUNTILhave inconsistent timezone awareness. However, the error message incorrectly suggests thatUNTILmust be specified in UTC, even whenUNTILis already in UTC and the actual problem is a timezone-naiveDTSTART.This pull request:
DTSTARTandUNTILmust both be timezone-aware or both be timezone-naive.AUTHORS.md.Testing
The complete test suite was executed locally using:
python -m pytest -qBefore changes:
After changes:
The targeted regression tests also passed (2 passed).
Python version: 3.13.12
Pull Request Checklist