Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1611.
In RFC 5545 section 3.8.2.4, property parameters may appear in any order. In
_rrulestr._parse_rfc, the regex extracting timezone names (TZID_NAMES) was matchingTZID=(?P<name>[^:]+):. If another parameter (such asVALUE=DATE-TIME) followedTZIDbefore the colon separator,[^:]+captured;VALUE=DATE-TIMEas part of the timezone name, leading to aKeyErrorduring lookup inrule_tzidsand silently dropping the timezone.Changes
TZIDextraction regex to stop at semicolons or colons ([^:;]+) and recognizeTZIDcase-insensitively.tests/test_rrule.pycoveringDTSTARTwithTZIDprecedingVALUE=DATE-TIME, case-insensitive parameter names, andEXDATEwithTZIDprecedingVALUE=DATE-TIME.