Handle bare UTC and GMT in tzstr#1492
Open
Sean-Kenneth-Doherty wants to merge 4 commits into
Open
Conversation
a0a9ccd to
3ab4893
Compare
3ab4893 to
3bd625a
Compare
Author
|
CI note: after the formatting/PyPy compatibility follow-up, the code checks and test matrix are passing on this head (including PyPy 2.7). The remaining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1432.
Summary
GMTandUTC, asserting they produce zero-offset zones instead of raisingTypeError.Tests
PYTHONPATH=src uv run --no-project --with pytest --with six --with hypothesis python -m pytest -q tests/test_tz.py::TZStrTest::testBareUtcGmtOffset tests/test_tz.py::TZStrTest::testPosixOffset(2 passed)PYTHONPATH=src uv run --no-project --with pytest --with six --with hypothesis python -m pytest -q tests/test_tz.py -m tzstr -p no:warnings(71 passed, 1 skipped, 352 deselected)PYTHONPATH=src python -m compileall -q src/dateutil/tz/tz.py tests/test_tz.py docs/conf.pygit diff --check origin/master...HEAD && git diff --checkNote: the broader
tzstrrun uses-p no:warningsbecause this throwaway local environment does not includepytest-cov, which normally registers theno_covermark used by the test config.