Reject invalid ISO week dates#1489
Open
Sean-Kenneth-Doherty wants to merge 3 commits into
Open
Conversation
2d16282 to
40b91ef
Compare
Author
|
The Python/platform test matrix for this parser change is passing. The prior red docs job was from Sphinx linkcheck hitting external URLs ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1236.
Summary
2021-W53coverage for dashed and compact week-date forms.Tests
PYTHONPATH=src python - <<'PY' ...checked2021-W53,2021-W53-1,2021W53, and2021W531now raise while valid2020-W53forms still parse.PYTHONPATH=src uv run --no-project --with pytest --with pytest-cov --with six --with hypothesis python -m pytest tests/test_isoparser.py tests/property/test_isoparse_prop.py -qPYTHONPATH=src python -m compileall -q src/dateutil/parser/isoparser.py tests/test_isoparser.pypython -m py_compile docs/conf.pyuv run --no-project --with pre-commit pre-commit run --files src/dateutil/parser/isoparser.py tests/test_isoparser.pygit diff --checkI also tried the full
testssuite with the same ephemeral uv environment. The parser change was not implicated, but local collection/execution failed in timezone tests because this source checkout does not includesrc/dateutil/zoneinfo/dateutil-zoneinfo.tar.gz.