fix(parser): skip extra numeric tokens in fuzzy mode instead of overflowing YMD#1480
Open
armorbreak001 wants to merge 1 commit into
Open
fix(parser): skip extra numeric tokens in fuzzy mode instead of overflowing YMD#1480armorbreak001 wants to merge 1 commit into
armorbreak001 wants to merge 1 commit into
Conversation
…lowing YMD When fuzzy parsing a string like '04/04/04 +32423', trailing numeric tokens after a complete YMD date was parsed would be appended to the ymd list unconditionally, causing resolve_ymd() to fail with 'More than three YMD values'. In fuzzy mode, these extra numeric tokens should be skipped rather than causing a parse failure. Fixes dateutil#95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fuzzy parsing a string like
04/04/04 +32423, trailing numeric tokens encountered after a complete YMD date has been parsed were appended to the ymd list unconditionally. This causedresolve_ymd()to fail with "More than three YMD values", which in turn madeparse()raiseParserErroreven though a valid date was present in the string.In fuzzy mode, extra numeric tokens that would overflow YMD should be skipped (similar to how non-numeric junk tokens are handled) rather than causing the entire parse to fail.
Before:
After:
Fixes #95