Fixes for roundToNearestMinutes() #3467
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3429 demonstrated that
roundToNearestMinutes()did not produce expected behaviour. This PR makes a few changes so thatroundToNearestMinutes()fixes that misbehaviour...addedMinutesvariable which added minutes on to the result. There was no obvious reason for this, and it could only ever cause the result to go wrong: indeed, this seemed to be the chief culprit in the case ofroundToNearestMinutesproducing unexpected results #3429. I have removed this variableround, but in fact it was defaulting totrunc. I have fixed this as well.Now, all tests pass, and I have manually checked that this should fix #3429