Added support for ceil and floor in roundToNearestMinutes #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Balastrong |
tan75
previously requested changes
Jul 10, 2022
Contributor
tan75
left a comment
tan75
left a comment
There was a problem hiding this comment.
A good idea 🙏
Please change this function to use the existing rounding options.
Contributor
Author
Ah I was doing some research for #3092 but I didn't mean to commit them on this branch, I'll remove that commit. |
Balastrong
force-pushed
the
feature/3063-added-support-for-ceil-floor-to-roundToNearestMinutes
branch
from
2647827 to
239f9dc
Compare
Balastrong
deleted the
feature/3063-added-support-for-ceil-floor-to-roundToNearestMinutes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed #3063
Added an optional field to options on
roundToNearestMinutesto toggle betweenMath.floorandMath.ceil, with default onfloor.