Fix bug in areIntervalsOverlapping (#3628) (closes #3614)

imwh0im · web-flow · commit 9ac551ce5c4f · 2023-12-22T14:57:56.000+08:00
Fixed bug in `areIntervalsOverlapping` caused by incorrect sorting
diff --git a/src/areIntervalsOverlapping/index.ts b/src/areIntervalsOverlapping/index.ts
@@ -71,11 +71,11 @@ export function areIntervalsOverlapping(
   const [leftStartTime, leftEndTime] = [
     +toDate(intervalLeft.start),
     +toDate(intervalLeft.end),
-  ].sort();
+  ].sort((a, b) => a - b);
   const [rightStartTime, rightEndTime] = [
     +toDate(intervalRight.start),
     +toDate(intervalRight.end),
-  ].sort();
+  ].sort((a, b) => a - b);
 
   if (options?.inclusive)
     return leftStartTime <= rightEndTime && rightStartTime <= leftEndTime;
diff --git a/src/areIntervalsOverlapping/test.ts b/src/areIntervalsOverlapping/test.ts
@@ -142,6 +142,14 @@ describe("areIntervalsOverlapping", () => {
     assert(isOverlapping);
   });
 
+  it('sort timestamp', () => {
+    const result = areIntervalsOverlapping(
+      { start: '1970-01-01T02:00:00.000Z', end: '1970-01-01T03:00:00.000Z' },
+      { start: '1969-12-31T23:30:00.000Z', end: '1970-01-01T02:30:00.000Z' },
+    );
+    assert(result);
+  })
+
   it("returns result for the normalized intervals if the start date of the initial time interval is after the end date", () => {
     const includedIntervalStart = new Date(2016, 10, 14);
     const includedIntervalEnd = new Date(2016, 10, 14);
