Conflate CommandOptions into [Collection|Table]FindManyOptions for Find#180
Conversation
|
The latest direction of this PR is to avoid two 'options' parameters and have the very FindManyOptions class(es) extend CommandOptions to capture all options. This required a bit of machinery between the various classes involved, which should be considered as there's the potential for mistakes such as forgetting to add a new CommandOptions field in one of the 'extraction' and clone methods:
|
fe8faf5 to
f7db234
Compare
|
I'm completing this PR with the conflation of CommandOptions into InsertManyOptions as well.
(@skedwards88 this is possibly reflected somewhere in the docs?) |
Fixes #179 .
Fixes #166 .
(while we're at it...)
Fixes #185 as well.
Specifically it adds a single overload with all three parameters, likely enough for the (probably uncommon) case of users who want to set options to the cursor.Update: changed to use a single options parameter that now also includes the CommandOptions stuff.
Along the way, a little restructuring of the xmldocs is done (now it's uniformly structured).
Also a basic test is added to check the options do indeed make their way to the fecth-page executions.
Note: changes like this would require a duplicate test on tables to really test everything. Note for the future: expand test coverage, since not everything about find is in the shared Abstract/Cursor classes.