ZCU-PUB/ORCID-badge#1293
Merged
Merged
Conversation
* Add orcid hyperlink to author in item view * Url orcid fetch from backend instead of hardcoded * Remove duplicate import * Fix unit test * Handled edge cases with orcid domain url * Usinng behaviour subject * Removed not wanted async property --------- Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
* Fixed ORCID badge --------- Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
There was a problem hiding this comment.
Pull request overview
Adds ORCID-specific rendering for authority-controlled author metadata in the plain-text metadata list element, using a backend-configured ORCID domain URL to generate a clickable ORCID badge/link.
Changes:
- Fetch
orcid.domain-urlviaConfigurationDataServiceand expose it to the template for ORCID link generation. - Render authority-controlled values as an ORCID link + ORCID icon when the authority matches an ORCID iD pattern; otherwise keep plain-text rendering.
- Add styling for the ORCID link/icon and extend unit tests (including updating the loader spec to provide
ConfigurationDataService).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.ts | Loads ORCID domain config and adds ORCID detection/URL helpers. |
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.html | Conditionally renders ORCID authority as external link with icon. |
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.scss | Adds styling for ORCID link/icon. |
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.spec.ts | Adds test coverage for ORCID/non-ORCID behavior and URL building. |
| src/app/shared/metadata-representation/metadata-representation-loader.component.spec.ts | Updates test setup to provide ConfigurationDataService dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Issue: https://github.com/dataquest-dev/dspace-customers/issues/507
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review