MENDELU/ORCID hyperlinks#1271
Merged
milanmajchrak merged 9 commits intoApr 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds ORCID profile hyperlinks for authority-controlled metadata entries so ORCID identifiers render as clickable external links (with an ORCID icon), addressing issue #520.
Changes:
- Added ORCID authority detection and URL construction helpers to the plain-text metadata list element component.
- Updated the template to render ORCID authorities as external links (and non-ORCID authorities as plain text).
- Added SCSS styling for the ORCID link/icon and unit tests covering ORCID vs non-ORCID authority cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.ts | Adds ORCID format detection and ORCID URL builder methods. |
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.html | Renders ORCID authorities as external links with an icon; keeps non-ORCID authority rendering as plain text. |
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.scss | Introduces styling for the ORCID link and icon. |
| src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.spec.ts | Adds unit tests verifying ORCID link/icon rendering and helper method behavior. |
2 tasks
milanmajchrak
requested changes
Apr 1, 2026
milanmajchrak
requested changes
Apr 1, 2026
milanmajchrak
added a commit
that referenced
this pull request
May 22, 2026
* MENDELU/ORCID hyperlinks (#1271) * Add orcid hyperlink to author in item view * Url orcid fetch from backend instead of hardcoded * Remove duplicate import * Fix unit test * Handled edge cases with orcid domain url * Usinng behaviour subject * Removed not wanted async property --------- Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk> * MENDELU/Fixed ORCID badge (#1272) * Fixed ORCID badge --------- Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk> * ZCU-PUB/Fix ORCID cherry-pick test conflict artifacts * ZCU-PUB/Reuse async ORCID domain binding in template --------- Co-authored-by: Kasinhou <129340513+Kasinhou@users.noreply.github.com> Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Issue: https://github.com/dataquest-dev/dspace-customers/issues/520
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review