Skip to content

UFAL/Cherrypick CC license#1024

Merged
milanmajchrak merged 24 commits into
dtq-devfrom
ufal/cherrypick-cc-license
Jan 13, 2026
Merged

UFAL/Cherrypick CC license#1024
milanmajchrak merged 24 commits into
dtq-devfrom
ufal/cherrypick-cc-license

Conversation

@jr-rk

@jr-rk jr-rk commented Oct 2, 2025

Copy link
Copy Markdown
Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Cherry-pick of new features: CC license
pull/1011
pull/1009
pull/966

jr-rk and others added 6 commits September 26, 2025 15:39
* Created Creative Common license view for the Item Page view

* Corrected grammar mistakes, updated hover animation for cc icons

* Removed debug method and improved performance
…1009)

* Fixed still loading of the `Saving` bar for the CC licenses

* Removed unnecessary files
@jr-rk jr-rk requested review from Copilot and milanmajchrak October 2, 2025 09:40
@jr-rk jr-rk self-assigned this Oct 2, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements Creative Commons (CC) license support functionality by cherry-picking features from multiple upstream pulls. It adds license detection, display, and submission handling for items.

  • Adds internationalization support for CC license display text
  • Implements a new CreativeCommonsLicenseFieldComponent for displaying CC licenses on item pages
  • Enhances the submission component with debounced CC license updates and better state management

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/assets/i18n/en.json5 Adds English translations for CC license labels and descriptions
src/assets/i18n/cs.json5 Adds Czech translations for CC license labels and descriptions
src/app/submission/sections/cc-license/submission-section-cc-licenses.component.ts Implements debounced license updates and improved state management
src/app/item-page/simple/item-types/untyped-item/untyped-item.component.html Integrates CC license field display
src/app/item-page/simple/item-types/publication/publication.component.html Integrates CC license field display
src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.ts Main CC license detection and display logic
src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.spec.ts Comprehensive test suite for CC license component
src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.scss Styling for CC license display
src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.html Template for CC license display with icons
src/app/item-page/item-page.module.ts Module registration for new component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@milanmajchrak milanmajchrak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict

@jr-rk jr-rk requested a review from milanmajchrak November 5, 2025 08:41

@milanmajchrak milanmajchrak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run sync messages tool?

Comment thread src/app/item-page/simple/item-types/publication/publication.component.html Outdated
Comment thread src/app/item-page/simple/item-types/untyped-item/untyped-item.component.html Outdated
@jr-rk jr-rk requested a review from milanmajchrak November 6, 2025 11:37
Comment thread src/assets/i18n/cs.json5 Outdated

@vidiecan vidiecan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the other similar PR

@milanmajchrak

Copy link
Copy Markdown
Collaborator

#1019 (comment)

@jr-rk

jr-rk commented Nov 12, 2025

Copy link
Copy Markdown
Author

I have replied on the previous comment

@jr-rk jr-rk requested a review from vidiecan November 12, 2025 12:44
@vidiecan

Copy link
Copy Markdown

@milanmajchrak resolve comments if you are happy with them

@milanmajchrak milanmajchrak merged commit e8ae588 into dtq-dev Jan 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants