Skip to content

UFAL/Manage Handles table UI finetunes#1019

Merged
milanmajchrak merged 17 commits into
dtq-devfrom
ufal/manage-handles-table-finetunes
Nov 24, 2025
Merged

UFAL/Manage Handles table UI finetunes#1019
milanmajchrak merged 17 commits into
dtq-devfrom
ufal/manage-handles-table-finetunes

Conversation

@jr-rk

@jr-rk jr-rk commented Sep 26, 2025

Copy link
Copy Markdown
Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

  • Fix inconsistencies
  • Make the "Internal" search strictly Yes/No via a dropdown.
  • Make the "Resource Type" search a dropdown with specific options (Item, Collection, Community).
  • Check possibility to simplify switch statement - lowercase constants
  • Add translation keys (i18n)

@jr-rk jr-rk self-assigned this Sep 26, 2025
@jr-rk jr-rk requested a review from Copilot September 26, 2025 14:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements UI improvements for the handle table search functionality by adding dropdown-based search options and fixing capitalization inconsistencies. The changes enhance user experience by providing structured search inputs for "Internal" and "Resource Type" fields instead of free-text input.

  • Replace free-text search with dropdown selections for Internal (Yes/No) and Resource Type fields
  • Fix capitalization inconsistency in the "Is Internal" label
  • Add helper methods to manage dropdown selections and display names

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
src/assets/i18n/en.json5 Fixed capitalization of "Is Internal" label from "Is Internal" to "Is internal"
src/app/handle-page/handle-table/handle-table.component.ts Added methods for handling dropdown selections and resource type display names
src/app/handle-page/handle-table/handle-table.component.html Replaced text input with conditional dropdowns for Internal and Resource Type search options

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
@jr-rk jr-rk requested a review from milanmajchrak September 29, 2025 08:33
@jr-rk jr-rk linked an issue Sep 29, 2025 that may be closed by this pull request
2 tasks

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/app/handle-page/handle-table/handle-table.component.html
Comment thread src/app/handle-page/handle-table/handle-table.component.ts Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.ts Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.scss Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/app/core/handle/HandleResourceTypeIdserializer.ts Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.html Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.ts Outdated
Comment thread src/app/handle-page/handle-table/handle-table.component.ts Outdated
@jr-rk jr-rk requested a review from Copilot October 30, 2025 11:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/app/handle-page/handle-table/handle-table.component.ts

@milanmajchrak milanmajchrak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Copilot
  2. Conflict

@jr-rk jr-rk requested a review from milanmajchrak November 5, 2025 08:30

@milanmajchrak milanmajchrak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run sync tool?

Comment thread src/app/handle-page/handle-table/handle-table.component.scss Outdated
@jr-rk jr-rk requested a review from milanmajchrak November 6, 2025 11:49
Comment thread src/assets/i18n/cs.json5
@milanmajchrak milanmajchrak merged commit bec11cb into dtq-dev Nov 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UFAL/Manage Handles table UI - add choice inputs

4 participants