Skip to content

Feature/overide sniffed csv settings#66

Merged
alexbourret merged 21 commits into
feature/add-mtlsfrom
feature/overide-sniffed-csv-settings
May 18, 2026
Merged

Feature/overide sniffed csv settings#66
alexbourret merged 21 commits into
feature/add-mtlsfrom
feature/overide-sniffed-csv-settings

Conversation

@alexbourret
Copy link
Copy Markdown
Collaborator

@alexbourret alexbourret commented Mar 11, 2026

Comment thread python-lib/dku_utils.py Outdated
@RoyTeddy
Copy link
Copy Markdown

RoyTeddy commented May 13, 2026

@alexbourret strange to display labels on the right for the connector
image

for the recipe labels are on the left
image

Comment thread python-lib/dku_utils.py Outdated
@alexbourret
Copy link
Copy Markdown
Collaborator Author

@alexbourret strange to display labels on the right for the connector image

for the recipe labels are on the left image

There is no much I can do on that one though, it's either on the right, or on the top like this:
api-connect-csv-ui

@RoyTeddy
Copy link
Copy Markdown

@alexbourret strange to display labels on the right for the connector image
for the recipe labels are on the left image

There is no much I can do on that one though, it's either on the right, or on the top like this: api-connect-csv-ui

top is better IMO

@alexbourret
Copy link
Copy Markdown
Collaborator Author

@alexbourret strange to display labels on the right for the connector image
for the recipe labels are on the left image

There is no much I can do on that one though, it's either on the right, or on the top like this: api-connect-csv-ui

top is better IMO

👍 changed in bba5751

@RoyTeddy
Copy link
Copy Markdown

RoyTeddy commented May 13, 2026

found a bug in decode_csv_data_m2() data.splitlines() corrupts quoted multiline fields.

for example:

app = Flask(__name__)

@app.route('/guid', methods=['GET'])
def get_guid():
    return str(uuid.uuid4()) + "\n" + str(uuid.uuid4())

@RoyTeddy
Copy link
Copy Markdown

RoyTeddy commented May 13, 2026

codex finding

  • Medium: the UI exposes quoting values 4 and 5 (Strings / Not null), but this repo is currently running
    on Python 3.9.23, where csv only supports quoting values 0..3. Selecting those new options will raise
    TypeError: bad "quoting" value. References: python-connectors/api-connect_dataset/connector.json:310,
    custom-recipes/api-connect/recipe.json:363

not a regression so not do it now

Copy link
Copy Markdown

@RoyTeddy RoyTeddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested 👍

…of-paths

Feature/accept mtls keys instead of paths
…sets

Feature/move mtls settings to presets
@alexbourret alexbourret merged commit daaf80f into feature/add-mtls May 18, 2026
@RoyTeddy RoyTeddy deleted the feature/overide-sniffed-csv-settings branch May 18, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants