Update setup.py and pypi long description #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antaresc
approved these changes
Aug 13, 2019
antaresc
suggested changes
Aug 13, 2019
Contributor
antaresc
left a comment
antaresc
left a comment
There was a problem hiding this comment.
https://packaging.python.org/tutorials/packaging-projects/#setup-args
We can actually read in the LONG_DESCRIPTION from README.md like so in the example above.
Contributor
Author
|
Updated to use README.md for long description |
antaresc
reviewed
Aug 13, 2019
setup.py
Outdated
| version=VERSION, | ||
| description=DESCRIPTION, | ||
| long_description=long_description, | ||
| long_description_content_type="text/markdown", |
Contributor
There was a problem hiding this comment.
Nit: change double quotes to single quotes for consistency.
antaresc
approved these changes
Aug 13, 2019
Contributor
antaresc
left a comment
antaresc
left a comment
There was a problem hiding this comment.
PTAL at comment before merging. Thanks!
antaresc
added a commit
that referenced
this pull request
Oct 2, 2019
* Fix typo in places.py. (#71) (#84) * Added iPynb notebooks and fixed issue #67 (#86) * Added notebooks * Added --upgrade flag * Update requirements and setup.py * Added maintenance information to the readme * Update setup.py and pypi long description (#87) * Update setup.py and requirements * Add long description for pypi package * Use README.md as the long description * Use single quote * Fixed docs and updated changelog (#89) * Amended documentation for creating a key. * Updated CHANGELOG * Spacing * Added 0.4.3 changes * Added 0.x to changelog * Add get_pop_obs api (#93) * Add get_pop_obs api * Updated comments with more detailed description. * Update comment and rst file * Updated comments * Move to populations module * Add missing change * Correct typo * More typo correction * Add comments on observations field * Add the step to join google group (#95) * Add more details for joining google group (#96) * Implemented get_place_obs and reimplemented query (#94) * Implemented get_place_obs * Reimplemented query as a function instead of a class. * query now returns a list. Amended docstrings. * Fixed docstring typo * Add observation_date as argument to get_place_obs (#97) * Add observation_date as argument to get_place_obs * Update doc string * Update test * fix link to getting started on read the docs home page (#98) * Fixed bug regarding indexing (#100) * Updated the changelog (#101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.