Skip to content

[CT-3637] - fix/add mathJax property and fix section styles #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ztsorojev merged 1 commit into from
Jun 28, 2022
Merged

[CT-3637] - fix/add mathJax property and fix section styles #118

ztsorojev merged 1 commit into from
Jun 28, 2022

Conversation

@ben-brooker
Copy link
Contributor

@ben-brooker ben-brooker commented Jun 28, 2022

TICKET

  • The latex would render successfully but fail if the page was refreshed. I asked the developer of the package and they suggested an adjustment that I could make to fix it (in the API section of the readme).
  • There are also dt, dd and dl elements in the 'value' section that need to have the styling applied so I adjusted that too, here are some comparisons:

Screenshot 2022-06-28 at 15 29 19

Screenshot 2022-06-28 at 15 30 45

@ben-brooker ben-brooker requested a review from ztsorojev June 28, 2022 14:32
@ben-brooker ben-brooker changed the title [CTfix/add mathJax property and fix section styles [CT-3637] - fix/add mathJax property and fix section styles Jun 28, 2022
ztsorojev
ztsorojev approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ztsorojev ztsorojev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that you asked the developer! You can even point to the code in this repo btw since its open source 👍

@ztsorojev ztsorojev merged commit 8cda8ce into main Jun 28, 2022
@ztsorojev ztsorojev deleted the bb/fix-latex-rendering branch June 28, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ztsorojev ztsorojev ztsorojev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ben-brooker @ztsorojev