Skip to content

created util method to normalise http protocol in http path#724

Merged
nikhilsuri-db merged 10 commits intomainfrom
PECOBLR-1446
Jan 5, 2026
Merged

created util method to normalise http protocol in http path#724
nikhilsuri-db merged 10 commits intomainfrom
PECOBLR-1446

Conversation

@nikhilsuri-db
Copy link
Contributor

@nikhilsuri-db nikhilsuri-db commented Dec 30, 2025 •
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Problem
Feature flag and telemetry endpoints were double-prepending https:// when server_hostname already included the protocol, causing https://https://host.com URLs. This broke telemetry for dbt-databricks users who configure hostnames with https:// prefix.

Solution
Added normalize_host_with_protocol() utility to handle protocol normalization
Updated feature flag and telemetry clients to use: normalize_host_with_protocol(host) + "/path"
Handles hostnames with/without protocol and trailing slashes

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

#709

@nikhilsuri-db nikhilsuri-db self-assigned this Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@nikhilsuri-db
created util method to normalise http protocol in http path
14915d2 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
Added impacted files using util method
81ec814 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
Fixed linting issues
ef4f92c 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@nikhilsuri-db
fixed broken test with mock host string
e982615 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
mocked http client
5ae79ce 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
samikshya-db
samikshya-db approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@samikshya-db samikshya-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments, thanks!

@nikhilsuri-db
made case sensitive check in url utils
cca26eb 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
linting issue resolved
a5c698c 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
removed unnecessary md files
5f9954f 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
@nikhilsuri-db
made test readbale
23af8e2 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
samikshya-db
samikshya-db reviewed Dec 31, 2025
View reviewed changes
@samikshya-db samikshya-db self-requested a review December 31, 2025 09:30
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@nikhilsuri-db
changes done in auth util as well as sea http
f8dad10 
Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>
jprakash-db
jprakash-db approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@jprakash-db jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes

@nikhilsuri-db nikhilsuri-db merged commit 946a265 into main Jan 5, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samikshya-db samikshya-db samikshya-db approved these changes

@jprakash-db jprakash-db jprakash-db approved these changes

Assignees

@nikhilsuri-db nikhilsuri-db

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikhilsuri-db @samikshya-db @jprakash-db