Skip to content

[PECO-1687] Fixed the issue of infinite blocking in case of invalid credentials #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jprakash-db wants to merge 6 commits into from
Closed

[PECO-1687] Fixed the issue of infinite blocking in case of invalid credentials #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98fc645
[PECO-1687] Fixed the issue of infinite blocking in case of invalid c…
jprakash-db Jun 17, 2024
1203a62
Incorporated the 401 status code error into the NonRecoverableNetwork…
jprakash-db Jun 17, 2024
594a85a
Moved 401 error into a separate block
jprakash-db Jun 17, 2024
c332bde
Removed the .idea file
jprakash-db Jun 18, 2024
b631231
Fixed Merge Conflicts
jprakash-db Jul 8, 2024
162ce18
Fixed Linting using black
jprakash-db Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
# Icon must end with two \r
Icon

# IntelliJ Files
.idea

# Thumbnails
._*
Expand Down
5 changes: 3 additions & 2 deletions src/databricks/sql/auth/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,8 @@ def should_retry(self, method: str, status_code: int) -> Tuple[bool, str]:
default, this means ExecuteStatement is only retried for codes 429 and 503.
This limit prevents automatically retrying non-idempotent commands that could
be destructive.
5. The request received a 401 response, because this can never succeed.
6. The request received a 403 response, because this can never succeed.
5. The request received a 403 response, because this can never succeed.
6. The request received a 401 response, because the User credentials are invalid


Q: What about OSErrors and Redirects?
Expand All @@ -342,6 +342,7 @@ def should_retry(self, method: str, status_code: int) -> Tuple[bool, str]:
if status_code == 200:
return False, "200 codes are not retried"

# Invalid Credentials error. Don't retry
if status_code == 401:
raise NonRecoverableNetworkError(
"Received 401 - UNAUTHORIZED. Confirm your authentication credentials."
Expand Down