[PECO-1687] Fixed the issue of infinite blocking in case of invalid credentials#399
[PECO-1687] Fixed the issue of infinite blocking in case of invalid credentials#399jprakash-db wants to merge 6 commits intodatabricks:mainfrom
Conversation
jprakash-db
requested review from
andrefurlan-db,
benc-db,
jackyhu-db,
kravets-levko,
rcypher-databricks and
yunbodeng-db
as code owners
kravets-levko
left a comment
kravets-levko
left a comment
There was a problem hiding this comment.
Hi @jprakash-db! Thank you for your effort on fixing this issue! Changes look good, but please do few things before we can merge this:
- remove
.ideafolder - use existing
NonRecoverableNetworkErrorinstead ofAuthenticationFailureError
|
@kravets-levko Sure, I will make those changes |
|
@jprakash-db please also remove the |
Removed it @kravets-levko |
|
@jprakash-db Can you please resolve conflicts, so I can merge this PR? Thanks! |
|
@kravets-levko Resolved the merge conflicts |
|
@jprakash-db when you resolved conflicts, I got confused, because I clearly remember that your PR definitely contained a code for handing 401 status. And then, I realized that recently we merged #408 🤦♂️ Sorry for asking you to do the job which is no longer needed. Fortunately, such overlaps don't happen often |
|
@kravets-levko Ya, while merging I too saw, that someone had already fixed it 😅 |
2 participants
Uh oh!
There was an error while loading. Please reload this page.