Fix componentreflection test - #328
Merged
Merged
Conversation
Databricks returns an empty string in the REMARKS column rather than a `NoneType`. Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
requested review from
andrefurlan-db,
arikfr and
yunbodeng-db
as code owners
January 23, 2024 20:56
susodapop
pushed a commit
to cbornet/databricks-sql-python
that referenced
this pull request
Jan 23, 2024
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
pushed a commit
to cbornet/databricks-sql-python
that referenced
this pull request
Jan 23, 2024
This was missed in databricks#328 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Add support for table comments Signed-off-by: Christophe Bornet <cbornet@hotmail.com> * Use per-table DTE to get the table comments Signed-off-by: Christophe Bornet <cbornet@hotmail.com> * Revert pytest.ini change Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Fix typo in test name for columns. Move .engine and .compile into a base class. Scaffold in the Table Comment unit tests. Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Add unit tests for table comments Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Revert overrides since these aren't needed after #328 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Stop skipping table comment portions of ComponentReflectionTest Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Move DTE parsing into _parse.py Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Add e2e test using inspector Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Add unit test for new method in _parse.py Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> * Fix assertion in column comment test This was missed in #328 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> --------- Signed-off-by: Christophe Bornet <cbornet@hotmail.com> Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> Co-authored-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a quick fix follow-up to #306 which fixes the
ComponentReflectionTest. Since SQLAlchemy expects an empty column to be aNoneTyperather than''. In actual usage, this doesn't change user behaviour since both''andNoneTypeevaluate false-y.